search

indiefan / king_smith

Home Assistant Integration for King Smith treadmills (e.g. WalkingPad)
MIT License
17 stars 8 forks source link

Fix generated entity names #40

Closed pedropombeiro closed 3 months ago

pedropombeiro commented 3 months ago

This PR fixes the entity IDs generated when the device is initially created. Currently, the entities are being all added with the same name, causing the entity IDs to appear as sensor.walking_pad, sensor.walking_pad2, sensor.walking_pad3, etc. With this change, the entities appear as follows:

image
indiefan commented 3 months ago

Thanks so much for sending this! Would love to integrate it. It looks like there are a few lint errors from missing docstrings. Would it be possible to fix those?

indiefan commented 3 months ago

(see follow up comment in other PR. Landing this despite lint errors)