search

indiesdev / curl

36 stars 15 forks source link

Update to Nodev16 and the latest version of @actions/core. #13

Closed Kiran-B closed 1 year ago

Kiran-B commented 1 year ago

This PR closes https://github.com/indiesdev/curl/pull/9, closes https://github.com/indiesdev/curl/issues/11 & closes https://github.com/indiesdev/curl/issues/12

Primary this PR includes two changes:

  1. Bump the version of @actions/core to 1.10.0. This should fix the usage of set-output.
  2. Update action.yml to declare the usage of Node v16. And hence the update of @types/node in package.json.

PR also includes below non-essential changes:

  1. Add typescript as a dev dependency. This is to remove the restriction of installing typescript as a global tool.
  2. Add build & clean scripts to package.json for easier build.
Kiran-B commented 1 year ago

@indiesdev @wphromma @beetlikeyg087 @EndBug Apologies for tagging and bothering you all. Did so owing to the time we have in front of us. GitHub has notified that actions that use set-output and Node v12 will not work after 31st May 2023. Refer:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/

Hence, requesting a review from you and merge/release if all looks good.

wphromma commented 1 year ago

Hi sorry for the late response and thanks for your contribution. So, LGTM. I will merge and release new vresion

cyberman54 commented 1 year ago

Thanks for the merge! New Release is still ongoing?

szmasood commented 1 year ago

Hi, can this PR please be included in a new release?

szmasood commented 1 year ago

@wphromma any updates on release?

cyberman54 commented 1 year ago

i opened issue #15 for this.