search

indieweb / indieauth

IndieAuth.net website code and IndieAuth Specification
52 stars 7 forks source link

naming consistency of anchor/section and link relation #16

Closed dret closed 6 years ago

dret commented 6 years ago

minor comment: https://www.w3.org/TR/2018/NOTE-indieauth-20180123/#redirect-url has a title and anchor that says URL whereas the redirect_uri link relation defined and described says URI. i'd suggest to make this consistent.

Zegnat commented 6 years ago

In what direction would you suggest this to be changed?

The link relation name is inherited from OAuth 2.0 Section 4.2.1, and the expected value of the relation should follow the URL standard. I would say both names are used in the right context.

IndieAuth refers to the URL standard, so that’s where people should be looking if they want to know how to handle the value of redirect_uri. For example when they need to add query parameters. As long as that standard is explicitly called out I do not think the value should be called anything other than a URL.

There are probably good reasons not to rename established OAuth link relations either.

aaronpk commented 6 years ago

@Zegnat is correct. The OAuth 2.0 parameter is redirect_uri, but in IndieAuth the value is always a URL.

dret commented 6 years ago

On 2018-01-26 22:08, Aaron Parecki wrote:

@Zegnat https://github.com/zegnat is correct. The OAuth 2.0 parameter is |redirect_uri|, but in IndieAuth the value is always a URL.

ok, in this case the names are well justified. i thought maybe it's just some inconsistent naming that can be easily fixed. thanks for the feedback!