Closed dmitshur closed 4 years ago
Thanks for this. Some of these are essentially typo fixes, and I'd like to be able to merge those first before discussing some of the other changes. Could you split those into their own PR?
Sure. Those are commits 2 and 3. Would you like them both in one PR, or two separate PRs?
Edit: I'll send them as 2 PRs unless you prefer otherwise.
@dmitshur actually let's just discuss the whole thing in this PR instead of splitting it up, since we have different ideas of what the typos are 😄
Resolved existing comments in the new push, PTAL.
This change is made of 4 logical and well-described commits (if this were Gerrit, I'd send a stack of 4 CLs) with the general theme of following up on #13 and improving consistency. Please see the commit messages of individual commits for full detail.
If you prefer to accept certain commits but not others, let me know and I can send them as individual PRs.