search

indieweb / indiewebify-me

Tools to help you get the best out of your indieweb site
http://indiewebify.me
166 stars 26 forks source link

Author linking fails between h-entry/u-author and external h-card/u-url #72

Open kaushalmodi opened 6 years ago

kaushalmodi commented 6 years ago

Hello,

Here is an example page: https://scripter.co/hugo-leaf-and-branch-bundles/

Inside h-entry

<a href="https://scripter.co/" class="u-author">Kaushal Modi</a>

Inside h-card

<div class="h-card">
    <a class="p-name u-url" href="https://scripter.co/">Kaushal Modi</a>
    <!-- snip -->
</div>

The author linking is working as per:

But https://indiewebify.me/validate-h-entry/?url=https%3A%2F%2Fscripter.co%2Fhugo-leaf-and-branch-bundles%2F gives:

You’re marking up your post’s author as a string — add h-card to make it a full h-card!

image

Can this please be fixed?

\cc @aaronpk

sknebel commented 6 years ago

This is pretty much part of #6, and something that has come up a fair bit recently in this specific form.

Do we have a readymade authorship algorithm implementation in PHP? I guess XRay contains one, not sure if it can easily be used standalone?

aaronpk commented 6 years ago

XRay does implement I believe the full authorship algorithm. We could pull XRay in to this project. The only trick is that it won't show detailed debugging information about why it found the author or not, it just returns the author info when it finds it.

aciccarello commented 11 months ago

I think this can be closed in favor of #6