GET or POST on preview - Githubissues

indieweb / microsub

For tracking issues on the Microsub specification

23 stars 0 forks source link

GET or POST on preview #34

Open sebsel opened 6 years ago

sebsel commented 6 years ago

I found two implementations that do not follow spec, and use GET instead of POST on the Preview action. These are also the only implementation that use the Preview action I could find.

Aperture accepts GET
Together sends GET
Monocle does not support Preview yet
Indigenous for iOS does not support Preview yet
the IndieWeb module for Drupal does not support Preview yet (https://github.com/swentel/indieweb/issues/250)

jackjamieson2 commented 5 years ago

Thanks for raising this question.

Yarns Microsub Server will accept either GET or POST for preview - https://github.com/jackjamieson2/yarns-microsub-server/blob/master/includes/class-yarns-microsub-endpoint.php#L217

I think Preview, and Search for that matter, make sense as GET requests

swentel commented 5 years ago

The Drupal module now supports preview on POST and GET - same for search. I agree with @jackjamieson2 that GET seems more logical.

Next up - search and preview from Indigenous for Android. I'll be sending a GET request there as I know a lot of people are using aperture.

aaronpk commented 5 years ago

I think my reasoning for requiring POST is that, unlike most read operations, this one will actually cause the server to go do work to fetch the URL and such. It felt like it would be more dangerous to allow that to happen on GETs, which may be easily triggered by CSRF and such, so requiring it be a POST is more explicit.