indieweb / wiki

Wiki backup and issue tracking for indieweb.org
https://indieweb.org/wiki/
The Unlicense
23 stars 8 forks source link

Inconsistent/limited search results causing confusion #40

Open gRegorLove opened 7 years ago

gRegorLove commented 7 years ago

@dougbeal discovered a search bug and we were able to narrow it down.

From the homepage, searching for a term should return all pages that contain that term in the title or body. For example, searching "rocks" should return the wiki pages https://indieweb.org/Webmention_Rocks and and https://indieweb.org/Micropub_Rocks. Instead it's returning only https://indieweb.org/everything because it contains the word "rocks" in the body. This was making it difficult for him (and I'm sure others) to find pages on the wiki.

There appears to be a difference between the built-in MediaWiki search form at https://indieweb.org/Special:Search (in the main content area) and the search form that appears at the top right. If you search rocks in the top right form, it only shows the more-limited results. If you use the one in the main content area, you get the fuller, expected results. Note that the homepage, where Doug was searching from, only has the more-limited search form.

Debugging the URLs it appears the difference that causes this is the redirs=0 URL param.

Compare: https://indieweb.org/wiki/index.php?title=Special%3ASearch&redirs=0&search=rocks&fulltext=Search&ns0=1

with: https://indieweb.org/wiki/index.php?title=Special%3ASearch&search=rocks&fulltext=Search

sknebel commented 7 years ago

I added the redirect parameter in https://indieweb.org/wiki/index.php?diff=38154&oldid=37902&rcid=38070 and it now works for me. Please confirm

gRegorLove commented 7 years ago

Thanks, @sknebel! That fixes it on the homepage. On internal pages the top-right search needs to be updated with that as well.

sknebel commented 7 years ago

Interesting, I thought I found during testing that that works, but you are right, it doesn't. no idea where to change that though