search

indieweb / wordpress-micropub

A Micropub Endpoint plugin for WordPress
https://wordpress.org/plugins/micropub
51 stars 12 forks source link

Stop including visible text in reply contexts #285

Closed snarfed closed 1 year ago

snarfed commented 1 year ago

...since they go inside since they go inside e-content, which webmention recipients use as the reply text.

https://chat.indieweb.org/wordpress/2023-02-27#t1677522099115700

snarfed commented 1 year ago

The PHP 5.6 failure looks unrelated. Does the code maybe no longer support PHP 5.6?

PHP Parse error:  syntax error, unexpected '[' in /home/runner/work/wordpress-micropub/wordpress-micropub/includes/class-micropub-endpoint.php on line 719
snarfed commented 1 year ago

Confirmed, the last merged PR (#282) did the same thing, passed on PHP 7.2 but failed on 5.6: https://github.com/indieweb/wordpress-micropub/actions/runs/3175919981

So we'll probably want to either raise the required PHP version or fix that incompatibility, but either way that's unrelated to this PR, so hopefully we can still merge this as is!

dshanske commented 1 year ago

I need to review the test process to see what introduced it

snarfed commented 1 year ago

Sure! I've moved that to #286, to clarify that it's separate and shouldn't block merging this PR.