FLI CCD camera can not reconnect after first connection

[danibeni]

I have been working with FLI CCD driver to include additional keywords in FITS header for a concrete project. After some tests I have realized that I can connect to the FLI CCD camera for the first time but the connection failed in next connections attemps saying that "indigo_try_global_lock(): failed to get lock.".

After some research I have found that in the ccd_change_property function the device->is_connected parameter is set to False before releasing the FLI resources using fli_close() function:

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L772

I think it is enough to put that line after the doing fli_close(device):

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L777

This way the resources are releases and unlocked properly before setting the is_connected parameter to False.

[rumengb]

Yes you are right! Thanks I will fix it today.

On Tue, Jan 14, 2020, 6:26 PM danibeni notifications@github.com wrote:

I have been working with FLI CCD driver to include additional keywords in FITS header for a concrete project. After some tests I have realized that I can connect to the FLI CCD camera for the first time but the connection failed in next connections attemps saying that "indigo_try_global_lock(): failed to get lock.".

After some research I have found that in the ccd_change_property function the device->is_connected parameter is set to False before releasing the FLI resources using fli_close() function:

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L772

I think it is enough to put that line after the doing fli_close(device):

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L777

This way the resources are releases and unlocked properly before setting the is_connected parameter to False.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBMVEYZBVM6LQCRHGW3Q5XRUNA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGDNXAA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBJD5VG5BRSZ3AZXLG3Q5XRUNANCNFSM4KGV4K2A .

[rumengb]

Fixed, Can you try it now?

On Tue, Jan 14, 2020 at 6:33 PM Rumen Bogdanovski rumen@skyarchive.org wrote:

Yes you are right! Thanks I will fix it today.

On Tue, Jan 14, 2020, 6:26 PM danibeni notifications@github.com wrote:

I have been working with FLI CCD driver to include additional keywords in FITS header for a concrete project. After some tests I have realized that I can connect to the FLI CCD camera for the first time but the connection failed in next connections attemps saying that "indigo_try_global_lock(): failed to get lock.".

After some research I have found that in the ccd_change_property function the device->is_connected parameter is set to False before releasing the FLI resources using fli_close() function:

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L772

I think it is enough to put that line after the doing fli_close(device):

https://github.com/indigo-astronomy/indigo/blob/ec3ad95dc22148245dfbf0bbf7612f7f7e7f225d/indigo_drivers/ccd_fli/indigo_ccd_fli.c#L777

This way the resources are releases and unlocked properly before setting the is_connected parameter to False.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBMVEYZBVM6LQCRHGW3Q5XRUNA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGDNXAA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBJD5VG5BRSZ3AZXLG3Q5XRUNANCNFSM4KGV4K2A .

[danibeni]

Ok, now it seems to work properly. Thank you

[rumengb]

What project is that? Can you give us some more information?

On Tue, Jan 14, 2020 at 6:55 PM danibeni notifications@github.com wrote:

Closed #274 https://github.com/indigo-astronomy/indigo/issues/274.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBLDSYPMMFQGLY3A3BDQ5XU7LA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV62LKDY#event-2947855631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBKEIAPVFH7MHVHW6J3Q5XU7LANCNFSM4KGV4K2A .

[danibeni]

We are using Indigo running on a Raspberry Pi 3 to control a ProLine FLI camera installed on a Schmidt telescope, but additional FITS keywords for the exposure start and end times are needed, so I have modified the FLI CCD driver to include this times for each image taken.

We are also working in the integration of the Schmidt based on Indigo to create an Astronomy Observation Suite, including drivers for our Schmiddt Telescope, dome and focus, and clients for the user interaction with the system and a scheduler, If you consider it interesting, I can give you more details when the project is in a more advanced state

[rumengb]

This is really interesting. I just added Indigo client programming guide to the repo. You may find it interesting.

Is this a professional or amateur project? Schmidt telescope sounds professional :) unless you mean schmidt-cassegrain... What observatory?

On Tue, Jan 14, 2020, 7:15 PM danibeni notifications@github.com wrote:

We are using Indigo running on a Raspberry Pi 3 to control a ProLine FLI camera installed on a Schmidt telescope, but additional FITS keywords for the exposure start and end times are needed, so I have modified the FLI CCD driver to include this times for each image taken.

We are also working in the integration of the Schmidt based on Indigo to create an Astronomy Observation Suite, including drivers for our Schmiddt Telescope, dome and focus, and clients for the user interaction with the system and a scheduler, If you consider it interesting, I can give you more details when the project is in a more advanced state

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBODH26UJ3V2W3QWGWLQ5XXKLA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI5NBIA#issuecomment-574279840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBLEJROXMCHFNQLMUSTQ5XXKLANCNFSM4KGV4K2A .

[rumengb]

Is that 0.8m Calar Alto Schmidt?

On Tue, Jan 14, 2020, 7:26 PM Rumen Bogdanovski rumen@skyarchive.org wrote:

This is really interesting. I just added Indigo client programming guide to the repo. You may find it interesting.

Is this a professional or amateur project? Schmidt telescope sounds professional :) unless you mean schmidt-cassegrain... What observatory?

On Tue, Jan 14, 2020, 7:15 PM danibeni notifications@github.com wrote:

We are using Indigo running on a Raspberry Pi 3 to control a ProLine FLI camera installed on a Schmidt telescope, but additional FITS keywords for the exposure start and end times are needed, so I have modified the FLI CCD driver to include this times for each image taken.

We are also working in the integration of the Schmidt based on Indigo to create an Astronomy Observation Suite, including drivers for our Schmiddt Telescope, dome and focus, and clients for the user interaction with the system and a scheduler, If you consider it interesting, I can give you more details when the project is in a more advanced state

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBODH26UJ3V2W3QWGWLQ5XXKLA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI5NBIA#issuecomment-574279840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBLEJROXMCHFNQLMUSTQ5XXKLANCNFSM4KGV4K2A .

[danibeni]

Correct!!! We are renewing the hardware and software related to the 0.8m CAHA Schmidt telescope and we are testing Indigo as base for the software control subsystem.

[rumengb]

Great! Our 2m RCC telescope at Rozhen works with indigo and several Andor cameras and with FLI on several 0.6m smaller telescopes... Also Several other observatories use it. I really want to establish Indigo as a professional framework. So if you need any support do not hesitate to contact us. And we really need what you are doing.. Astronomy Observation Suite...

On Tue, Jan 14, 2020 at 7:53 PM danibeni notifications@github.com wrote:

Correct!!! We are renewing the hardware and software related to the 0.8m CAHA Schmidt telescope and we are testing Indigo as base for the software control subsystem.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/274?email_source=notifications&email_token=AE5EZBPQS4QYVS7TEN5NCHTQ5X3YZA5CNFSM4KGV4K2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI5Q55Q#issuecomment-574295798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBLHXY3N6JTNKJR2FRDQ5X3YZANCNFSM4KGV4K2A .

[rumengb]

Hi @danibeni , I have sent you and answer to your e mail a week ago and now i got a reply that the mail has beed reused by your mail server. Please contact me via some other email. So that we can discuss the things you are interested in.