search

indigo-astronomy / indigo

INDIGO is a system of standards and frameworks for multiplatform and distributed astronomy software development designed to scale with your needs.
http://www.indigo-astronomy.org
Other
152 stars 70 forks source link

Fix lx200 problems #315

Closed tail-feather closed 4 years ago

tail-feather commented 4 years ago

Fixed some problems.

Please point out if I'm wrong.

1. Fixed no response after the :SCMM/DD/YY# command sent

According to the PDF, this command returns two delimiters.

"1Updating Planetary Data#                                #"

The second part seems a progress bar.

2. Fixed stop the coordinate update after MOUNT_ABORT_MOTION

Removed below code:

PRIVATE_DATA->position_timer = NULL;

3. Fixed initial state of EQUATORIAL_COORDINATES_RA/DEC target property

The reason why EQUATORIAL_COORDINATES property becomes BUSY after the connection is because the value of the target is different.

4. Fixed an accuracy problem in the process of detecting the completion

Although the accuracy is low in the Autodetect mode, the accuracy is too high in this condition.

fabs(MOUNT_EQUATORIAL_COORDINATES_RA_ITEM->number.value - MOUNT_EQUATORIAL_COORDINATES_RA_ITEM->number.target) < 1.0/3600.0
polakovic commented 4 years ago

Thank you very much, I'll check it. LX200 driver become a nightmare with more and more dialects supported :(

tail-feather commented 4 years ago

I understand your feelings. "Compatible" is always the cause of nightmare...

I tested with below models.

Please let me know if there is anything that is not working. I'm going to try to fix it.

tail-feather commented 4 years ago

Oops, Sorry LX200 GPS didn't work when I send :SCMM/DD/YY#... I'll check again...

polakovic commented 4 years ago

Yes, we should be very lenient for SC command :(