search

indigo-astronomy / indigo

INDIGO is a system of standards and frameworks for multiplatform and distributed astronomy software development designed to scale with your needs.
http://www.indigo-astronomy.org
Other
148 stars 64 forks source link

Add DARK FLATS option to frame type #387

Closed polakovic closed 3 years ago

rumengb commented 3 years ago

I do not think we need it. It will just clutter the property and it is basically a dark frame for the flat frame. There is no technical difference between dark frame and dark flat frame. It just have to match the flat exposure time. So there is no reason to do this.

On Fri, Nov 6, 2020, 4:45 PM Peter Polakovic notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBMSPQI2ZMLO7ABELG3SOQD2LANCNFSM4TMYLFCQ .

polakovic commented 3 years ago

The reason is, that it is copies to FITS metadata and/or file name. It is repeated user request...

Sent from my iPhone

On 7 Nov 2020, at 11:13, Rumen Bogdanovski notifications@github.com wrote:

 I do not think we need it. It will just clutter the property and it is basically a dark frame for the flat frame. There is no technical difference between dark frame and dark flat frame. It just have to match the flat exposure time. So there is no reason to do this.

On Fri, Nov 6, 2020, 4:45 PM Peter Polakovic notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBMSPQI2ZMLO7ABELG3SOQD2LANCNFSM4TMYLFCQ .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

polakovic commented 3 years ago

https://pixinsight.com/forum/index.php?threads/understand-darkflat-image-type-in-wbpp-bpp.14545/

polakovic commented 3 years ago

825b1d95c91b1225d58b3d72ab8bc6ed155af09d

jconejero commented 3 years ago

FWIW, we have had some passionate discussions about the terms 'dark flat' and 'flat dark'. See for example:

https://pixinsight.com/forum/index.php?threads/understand-darkflat-image-type-in-wbpp-bpp.14545/#post-88690

https://pixinsight.com/forum/index.php?threads/understand-darkflat-image-type-in-wbpp-bpp.14545/#post-88696

I personally prefer 'flat dark', but our preprocessing pipelines support both the FLATDARK and DARKFLAT FITS keywords. I would generate FLATDARK keywords because I think it's more correct semantically, but I'm not sure about compatibility with other applications.

Juan Conejero PixInsight Development Team Pleiades Astrophoto, S.L. https://pixinsight.com/

On 17/11/2020 20:47, Peter Polakovic wrote:

Closed #387 https://github.com/indigo-astronomy/indigo/issues/387.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/387#event-4007234300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIWSBCMGNITK4KDHVQMEG3SQLHOHANCNFSM4TMYLFCQ.

polakovic commented 3 years ago

Yes, I saw you support both. I googled a little bit and situation is unclear :)

jconejero commented 3 years ago

Absolutely unclear, of course. We're speaking of FITS, what did you expect? :D

On 17/11/2020 21:10, Peter Polakovic wrote:

Yes, I saw you support both. I googled a little bit and situation is unclear :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/indigo-astronomy/indigo/issues/387#issuecomment-729173473, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIWSBFFJZH6BOPXBJJOBYDSQLKFFANCNFSM4TMYLFCQ.