indigo-astronomy / indigo

INDIGO is a system of standards and frameworks for multiplatform and distributed astronomy software development designed to scale with your needs.
http://www.indigo-astronomy.org
Other
139 stars 64 forks source link

"sideofpier" property in alpaca_agent #466

Closed Paolo97Gll closed 1 year ago

Paolo97Gll commented 1 year ago

I'm using a SynScan EQ-8 mount with the mount_synscan driver. The indigo driver exposes the mount side of pier and I can see it from the control panel and ain imager. However, the corresponding alpaca request return "Property or method not implemented".

Here an example taken from my server:

Request:

/api/v1/telescope/1/sideofpier

Response:

{
"Value": 0,
"ErrorNumber": 1024,
"ErrorMessage": "Property or method not implemented",
"ClientTransactionID": 0,
"ServerTransactionID": 158757
}

I think that the expected behaviour, given the official description in this section of the ASCOM Alpaca Device API, should be to report the current side of pier since this method is implemented in indigo (it's a read-only permission, so a get request it's ok).

polakovic commented 1 year ago

Stupid typo :( Hopefully fixed here 4e5a14c13411251a5b8c6319464c6aa22c32d4e5, but not tested yet...

Paolo97Gll commented 1 year ago

I can test it in the next days, I will let you know if it works

Paolo97Gll commented 1 year ago

I confirm that it works as expected and results are consistent with the ones reported in the indigo server, thanks!

polakovic commented 1 year ago

👍

BobDenny commented 1 year ago

@polakovic Just a quickie... in case your typo was case-related, the newest release of Conform Universal has strict casing, runs native on Linux, Mac, and will catch this sort of thing because it speaks native Alpaca (not like the obsolete Windows Conform that runs through the Chooser Dynamic Drivers). So you can test right on your Linux system. It also has an Alpaca protocol checker that looks for botches in the protocol, HTTP status values for various errors, Transaction IDs, and error reporting. This conform will be the standard going forward. Excellent unit test tool.

polakovic commented 1 year ago

No, it was not case related. It was misplaced } :)