indigo-dc / java-reposync

Java implementation of the sync repositories functionality
1 stars 1 forks source link

nova api shows the same name for different docker images #36

Open orviz opened 8 years ago

orviz commented 8 years ago

Different images from the same docker repository appear in Glance with the same name. For instance, the images:

indigodatacloud/ci-images:python indigodatacloud/ci-images:java

synced with indigodc-reposync, are listed in Glance as:

# nova image-list 
(..)
| 2133caae-38f2-4df3-a0a3-be66643e0873 | indigodatacloud/ci-images                                                    |
| e14fb7f2-f78a-4680-9c80-b6dcba2f2766 | indigodatacloud/ci-images                                                    |

The tag should also be reflected in the last output.

jose-sanchezm commented 8 years ago

In the Nova Docker documentation https://github.com/openstack/nova-docker it says:

The name of the image in Glance should be explicitly set to the same name as the image as it is known to Docker. In the example above, an image has been tagged in Docker as 'busybox'. Matching this is the '--name busybox' argument to glance image-create. If these names do not align, the image will not be bootable.

In the example provided, I only see the name so I'm not sure what would be the name adding the tag. If it's as in docker, it should be name:tag but considering the lack of documentation I prefer to be sure before making the change.

Also in https://wiki.openstack.org/wiki/Docker all examples just use the image name, not the tag.

mariojmdavid commented 8 years ago

it maybe that we (indigo) will have to contribute/support/maintain nova-docker, so we should check how best to do this

alvarolopez commented 7 years ago

This should be fixed with this commit https://review.openstack.org/#/c/374040/