indigo-dc / jenkins-pipeline-library

Jenkins pipeline library with common functionalities for CI/CD environments, mainly targeted for the implementation of the SQA baseline requirements from https://indigo-dc.github.io/sqa-baseline/
Apache License 2.0
11 stars 6 forks source link

Tox builder seems to be expecting a tox file #143

Closed orviz closed 3 years ago

orviz commented 3 years ago

Even though the command tox itself does not require a configuration file to be provided, JePL is currently requesting that. The error eu.indigo.compose.DockerCompose.escapeWhitespace(DockerCompose.groovy:117) is obtained when no tox_file is provided (see sample failure)

samuelbernardolip commented 3 years ago

https://github.com/EOSC-synergy/DEEPaaS/blob/6398cb85d07a20b3df04c7b9826a1e05e906050e/.sqa/config.yml#L6L8

@orviz This is wrong and not expected... Tox configuration or any other build tool configuration only appears in the stage where it will run.

samuelbernardolip commented 3 years ago

https://github.com/EOSC-synergy/DEEPaaS/blob/6398cb85d07a20b3df04c7b9826a1e05e906050e/.sqa/config.yml#L7

@orviz tox.ini file when set should be the full path to the expected location inside container. In PR I was setting the full project path but that is wrong, because the tox will run inside container, so depends on the user configuration for the container itself. So always require the user or the auto-configuration system to set it as expected.

samuelbernardolip commented 3 years ago

Closing this issue, since is not a bug from JePL side.