Closed samuelbernardolip closed 3 years ago
We can avoid an additional attribute in config.yml using for that predefined environment variables.
Those can be set in environment namespace. The variable name syntax would be JPL_
Example:
config:
project_repos:
sqaaas_web:
repo: 'https://github.com/EOSC-synergy/sqaaas-web.git'
branch: jpl-branch
sqaaas_web2:
repo: 'https://github.com/EOSC-synergy/sqaaas-web.git'
branch: gh-pages
environment:
- JPL_SQAAAS_WEB_CRED: userpass_sqaaas_web
- JPL_SQAAAS_WEB2_CRED: userpass_sqaaas_web
@orviz This requires that schema be updated to only allow the characters expected in environment variables:
"config_repo": {
"type": "object",
"minProperties": 1,
"patternProperties": {
"[a-z0-9_]*": { "$ref": "#/definitions/config_repo_settings" }
}
},
This schema update is also important to keep code style.
Looking into the pros and cons related to the introduction of credentials, it's better to rely on config.yml configuration.
We need to add to the documentation the following: If you're using the ssh url then your credentials must be username + private key. If you're using the https clone url instead of the ssh one, then your credentials should be username + password.
Already implemented with #PR90.
Add an additional attribute to repository configurations in config section so is possible to checkout from private domain: