indigo-dc / orchestrator

The INDIGO PaaS Orchestrator
https://www.indigo-datacloud.eu/paas-orchestrator
Apache License 2.0
16 stars 21 forks source link

Improved Hybrid Deployment Topology #392

Closed mperniola closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #392 into master will increase coverage by 3.16%. The diff coverage is 42.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     60.42%   63.58%   +3.16%     
- Complexity      885      986     +101     
============================================
  Files           184      186       +2     
  Lines          5685     5869     +184     
  Branches        355      382      +27     
============================================
+ Hits           3435     3732     +297     
+ Misses         2112     1984     -128     
- Partials        138      153      +15     
Flag Coverage Δ Complexity Δ
#integration 8.17% <2.97%> (?) 172.00 <1.00> (?)
#unittests 59.83% <42.97%> (-0.59%) 911.00 <28.00> (+26.00) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
...ava/it/reply/orchestrator/config/IgniteConfig.java 87.50% <ø> (+87.50%) 3.00 <0.00> (+3.00)
...tor/config/filters/CustomRequestLoggingFilter.java 5.21% <ø> (+5.21%) 2.00 <0.00> (+2.00)
.../orchestrator/controller/DeploymentController.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...ly/orchestrator/controller/ResourceController.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...it/reply/orchestrator/dal/entity/OidcEntityId.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...it/reply/orchestrator/dto/cmdb/ChronosService.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../it/reply/orchestrator/dto/cmdb/CloudProvider.java 57.14% <ø> (ø) 3.00 <0.00> (ø)
...a/it/reply/orchestrator/dto/cmdb/CloudService.java 78.57% <ø> (ø) 11.00 <0.00> (ø)
...t/reply/orchestrator/dto/cmdb/MarathonService.java 70.00% <ø> (ø) 1.00 <0.00> (ø)
...y/orchestrator/dto/cmdb/MesosFrameworkService.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e18bcc...c51f7c2. Read the comment docs.

alberto-brigandi commented 4 years ago

@mperniola let me know when this PR is ready

mperniola commented 4 years ago

@alberto-brigandi the PR is ready; there is a lack of tests but for the moment I think it may be okay ...

alberto-brigandi commented 4 years ago

Except for a couple of questions, it looks good to me. Good job

sonarcloud[bot] commented 4 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

48.3% 48.3% Coverage
0.2% 0.2% Duplication