indigo-dc / udocker

A basic user tool to execute simple docker containers in batch or interactive systems without root privileges.
https://indigo-dc.github.io/udocker/
Apache License 2.0
1.36k stars 132 forks source link

Fixing command line elements to be able to use digest style image tags #356

Closed kellrott closed 2 years ago

kellrott commented 2 years ago

Updating behavior for dealing with tags that use the digest format (https://docs.docker.com/engine/reference/commandline/images/#list-image-digests)

Example:

udocker pull ubuntu@sha256:7c9c7fed23def3653a0da5bc9ecb651efe155ebd5802c7ba5d585edaa6c89496

Previously, this would have failed because the code would not accept the @ character. Split behavior/join also changes, using the @ rather then the :.

Previously this would have failed. For some tools, such as Cromwell using the digest form is considered to be best practice

mariojmdavid commented 2 years ago

this is not as simple as this PR would imply major refactoring and implementation not in the foreseeable developments