indigo-iam / iam

INDIGO Identity and Access Management Service
https://indigo-iam.github.io/
Other
102 stars 43 forks source link

Issue 705 iam admins should be able to suspend clients #715

Closed garaimanoj closed 5 months ago

garaimanoj commented 7 months ago
federicaagostini commented 6 months ago

Looks good to me, let's wait for the others :)

In the meantime, I don't know if it would make sense to add the possibility to disable client also to users who own the client (even if not admins). Right now, I don't see a side effect for that.

garaimanoj commented 6 months ago

Thanks for your review. I have noticed some JavaScript error. Currently trying to fix those. I will let you know once those are fixed. Shall I add the information of by whom and when the client was suspended in the dashboard in this pull request?

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

enricovianello commented 5 months ago

Replaced by #747