Closed cnelson20 closed 1 year ago
When you look at the files changed tab here there's a lot of spacing things VS2022 did for whatever reason. I don't know how to fix it but I'd be happy to if someone could demonstrate how
That's VS enforcing the style settings from the .clang_format configuration file. I don't mind the extra diffs, it means folks should have been doing more to run clang format as they went. Myself included.
I'm shaking my head that SDL_RWsize returns a signed 64-bit integer, while SDL_RWread expects a size_t for its read length, which is unsigned 32-bit on 32-bit platforms. It's a goofy API error that SDL2 doesn't mandate a signed 64-bit integer to match the type returned by SDL_RWsize, and it's the kind of thing that is why many libraries just typedef their own "size" type to use throughout an API.
I won't refuse the merge just because that breaks the 32-bit builds, though I will go ahead and fix it tonight.
Thanks for this!
Added banked RAM/ROM under ROM space
Added -romcart option
-romcart [bank to load] <filename>