indigotech / danger

Danger scripts for Taqtile projects
MIT License
1 stars 1 forks source link

[Opinion] How to implement it for all apps? #2

Closed felipesabino closed 7 years ago

felipesabino commented 8 years ago

What?

Danger allows a lot of automated testing and the goal of this plugin is to have a similar approach to Taqtile's Fastlane implementation, where most of the work for the repeated stuff is already done and most projects that just use default options have a minimal effort to setup but other also have the ability to do some custom stuff.

An initial POC for danger was already done at https://github.com/indigotech/fastlane/issues/33 with very custom metrics being retrieved from bash commands, which seems to allow any customization.

Example

The initial idea for a simple implementation is to have devs (and the template) just having to add this plugin to Gemfile and create a Dangerfile with something similar to simply calling

taqtile.run

Which would run all default checks, and that's what PR #1 initially did to implement and test https://github.com/indigotech/fastlane/issues/33 implementation as a plugin.

Current doubts

felipesabino commented 7 years ago

Used a Dangerfile that can be imported by just using import_dangerfile and github parameters.