search

indilib / indi-3rdparty

INDI 3rd Party drivers repository
https://www.indilib.org/devices.html
GNU Lesser General Public License v2.1
124 stars 208 forks source link

Adding AvalonUD support #854

Closed AvalonService closed 9 months ago

AvalonService commented 10 months ago

This is the initial public release of the AvalonUD (Avalon Unified Drivers) drivers that are compatible with the Avalon Instruments StarGO2Pro and StarGO+ controllers.

The release version number is 2.2 since it is aligned to the controllers internal software/firmware version.

It requires the ZeroMQ networking library and for this reason we tried to include it in the requisites script and added a new cmake_modules module.

A CMakeLists.txt file update has also been proposed to enable driver compilation.

We succefully tested build on 32bit Raspbian, 64bit Ubuntu and 64bit Fedora.

AvalonService commented 10 months ago

The new INDI style properties have been implemented. Please check thanks

knro commented 9 months ago

@pawel-soja Do we need to rebuild the CI image to include zeromq dependency for this to work?

sterne-jaeger commented 9 months ago

Is it really a good idea to create a separate directory? Why don't simply merge it into the existing indi-avalon?

AvalonService commented 9 months ago

We assumed this was the safest approach since the "avalon" driver is community-provided code for older hardware while "avalonud" is managed directly by Avalon Instruments and is the official driver for our new controllers. But obviously we are open to any suggestions...

sterne-jaeger commented 9 months ago

But obviously we are open to any suggestions...

As one of the developer of the StarGo driver, I would really appreciate if we use the same base directory. If there are changes necessary to merge the two of them, I'm happy to assist.

knro commented 9 months ago

@TallFurryMan Any idea why this is still failing? I added zeromq to the dependencies and the CI image was rebuilt?

sterne-jaeger commented 9 months ago

@knro it looks like the package libzmq3-dev is missing under Linux.

knro commented 9 months ago

I have under 22.04, it's missing for CI images?

sterne-jaeger commented 9 months ago

I had to add it in my Ubuntu 22.04.03 installation first. No idea whether it is part of the CI already.

knro commented 9 months ago

Will merge this now and hopefully we can fix the CI issue soon.

TallFurryMan commented 9 months ago

I think that the github action 115 on workflow Docker in the indi core repo, triggered by my merged PR, fixed the dependency issue. We'll see the result on the next PR or commit in the indi 3rd party repo, but I'm optimistic, at least for the zmq dep.