indilib / indi-3rdparty

INDI 3rd Party drivers repository
https://www.indilib.org/devices.html
GNU Lesser General Public License v2.1
124 stars 208 forks source link

[PREVIEW] Initial focuser support added to indi_celestron_aux #862

Closed ijessen closed 8 months ago

ijessen commented 9 months ago

This is functional - but testing has been limited. Most importantly, I haven't tested with an uncalibrated focuser.

I took a slightly different approach than the focuser implementation in the core celestrongps driver - namely I adopted the interface guidance that the absolute position property value ranges from 0 to max. I do this by applying an offset (the min value from calibration), and therefore the abs position value from the driver will be offset from the abs position displayed on the HC. I also skipped relative positioning because I don't see a use case for it when absolute is available.

Backlash not yet implemented.

Astyle not (yet) applied.

knro commented 9 months ago

Thanks! So what's the procedure exactly with a new uncalibrated focuser? Should there be a similar calibration workflow like in the HC driver?

ijessen commented 9 months ago

As is there's nothing here to initiate a calibration - the interface isn't loaded unless a valid calibration is already present (you would have to use an HC or other driver to launch the calibration routine). That said it's easy enough to add (and I see that there's an example to copy from in the dedicated celestron focuser driver in the core repo). I'll have some time later in the week to fiddle with it.

knro commented 9 months ago

@ijessen Did you test this? any issues?

ijessen commented 9 months ago

@ijessen Did you test this? any issues?

Haven't gotten around to adding in calibration support yet. I was waiting until I get to that before taking the PR out of draft. That said I've been using this in the field for a couple weeks and it's been rock solid.

knro commented 9 months ago

Awesome, looking forward to the final driver!

knro commented 8 months ago

@ijessen Any update? should we merge this as-is to get some community feedback? any show stoppers?