search

indilib / indi-3rdparty

INDI 3rd Party drivers repository
https://www.indilib.org/devices.html
GNU Lesser General Public License v2.1
124 stars 208 forks source link

indi-rpicam and aarch64 #863

Closed aaronwmorris closed 8 months ago

aaronwmorris commented 9 months ago

I was attempting to compile 2.0.5 on a Raspberry Pi OS 12 (bookworm) 64-bit aarch64 system and it was failing to compile the indi-rpicam server due to libmmal being an incorrect binary format.

It is my understanding that the libmmal library is 32-bit only on the armv6l and armv7l platforms.

From CMakeLists.txt

# MMAL Required for Raspberry PI camera driver
if (CMAKE_SYSTEM_PROCESSOR MATCHES "armv+" OR CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
find_package(MMAL)
endif()

IF (MMAL_FOUND)
option(WITH_RPICAM "Install Raspberry Pi High Quality Camera Driver" On)
ELSE ()
option(WITH_RPICAM "Install Raspberry Pi High Quality Camera Driver" Off)
ENDIF(MMAL_FOUND)

Should the MMAL library detection be removed for the aarch64 platform?

As a side note, I have libcamera compiled from source on this system. MMAL might not be installed otherwise.

knro commented 9 months ago

indi-rpicam is deprecated and is partially replaced by indi-libcamera. I think we should remove indi-rpicam from the repo.

aaronwmorris commented 9 months ago

No argument here. :-)