indilib / indi-3rdparty

INDI 3rd Party drivers repository
https://www.indilib.org/devices.html
GNU Lesser General Public License v2.1
123 stars 208 forks source link

The "Filter Slot" indicator in the Toupcam EFW driver is always busy #944

Closed jctk closed 1 month ago

jctk commented 1 month ago

Describe the bug The "Filter Slot" indicator in the Toupcam EFW driver "indi_toupcam_wheel" is always busy. A member function "ToupWheel::TimerHit()" did not work because "SetTimer()" function was not called when the filter was set.

To Reproduce Exact steps to reproduce the behavior.

  1. Set Toupcam EFW in the profile.
  2. Connect to Device from EKOS.
  3. Set the filter in the Filter Slot on the INDI control panel.
  4. The indicator will remain yellow and BUSY.
  5. Due to this issue, the capture module cannot start capturing while waiting for the filter to be set.

Expected behavior "Toupcam EFW" should go from busy to ready after the filter change is completed.

Desktop (please complete the following information):

jctk commented 1 month ago

The issue was fixed https://github.com/indilib/indi-3rdparty/pull/945