indilib / indi

INDI Core Library Repository
https://www.indilib.org
GNU Lesser General Public License v2.1
366 stars 387 forks source link

Liveview FIX for Sony Alpha Cameras #1034

Closed v4mp1 closed 4 years ago

v4mp1 commented 4 years ago

https://indilib.org/forum/ccds-dslrs/5881-sony-alpha-5100-viewfinder-widget-error-fixed.html

knro commented 4 years ago

Thank you for the fix. Is this applicable to all Sony cameras?

v4mp1 commented 4 years ago

I have only the 5100 but my guess is it works for the whole Sony DSLM android based firmware lineup.

knro commented 4 years ago

Ok I applied this to master, can you test and verify?

v4mp1 commented 4 years ago

I don't see any changes there?

https://github.com/indilib/indi-3rdparty/blob/master/indi-gphoto/gphoto_driver.cpp

knro commented 4 years ago

You're right, I pushed it to the gphoto_autoexposure branch by mistake. Can you test it there?

v4mp1 commented 4 years ago

Alright, I can test it in some hours. Thanks.

v4mp1 commented 4 years ago

Jasem it works but you forgot to add Sony in the stop preview section. I have to click twice on the X to close the preview window:

int gphoto_stop_preview(gphoto_driver *gphoto) { // Olympus cameras support streaming but without viewfinder_widget if (strcasestr(gphoto->manufacturer, "OLYMPUS")) return GP_OK;

v4mp1 commented 4 years ago

Everything works now Jasem you can upload to master.

Thanks.