indistudio / mollify

Automatically exported from code.google.com/p/mollify
0 stars 0 forks source link

Localizations missing #529

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Visit the permissions module of Mollify
2. Note some permission functionalities are showing their internal localization 
keys

The following are missing from the localization files:
permission_filesystem_item_access_value_ro
permission_filesystem_item_access_value_no
configAdminPermissionsRemoveConfirmationTitle
configAdminPermissionsRemoveConfirmationMessage

I've not done a comprehensive search yet, so there may be more.

Original issue reported on code.google.com by tom.ie...@gmail.com on 29 Mar 2014 at 7:31

GoogleCodeExporter commented 8 years ago
What language is this (I'm assuming this is not english, because those 
certainly exist in english language)? Can you provide the missing texts?

Other languages than english are a bit behind all the time, because I cannot 
translate them on my own. So I just have to add new features with english and 
wait for someone to update the localizations.

Original comment by samuli.j...@gmail.com on 30 Mar 2014 at 7:04

GoogleCodeExporter commented 8 years ago
It's english.

None of the localization files from 2.5.5 contain:
permission_filesystem_item_access_value_ro or 
permission_filesystem_item_accesz_value_no.

They have:
permission_filesystem_item_access_value_r and 
permission_filesystem_item_access_value_n

None of the localization files from 2.5.5 contain:
configAdminPermissionsRemoveConfirmationTitle or 
configAdminPermissionsRemoveConfirmationMessage

I can't find anything similar to make me think it's a typo.

I just downloaded 2.5.5 again to check this and used the following to look for 
the localization keys:

cd mollify
grep -ril permission_filesystem_item_access_value_ro *
grep -ril permission_filesystem_item_access_value_no *
grep -ril configAdminPermissionsRemoveConfirmationTitle *
grep -ril configAdminPermissionsRemoveConfirmationMessage *
grep -ril PermissionsRemoveConfirmation *

(The last one turns up the places in the js file where the removal confirmation 
is referred to...)

Original comment by tom.ie...@gmail.com on 30 Mar 2014 at 1:53

GoogleCodeExporter commented 8 years ago
OK, didn't check them that closely.

You are right about "configAdminPermissionsRemoveConfirmationTitle" and 
"configAdminPermissionsRemoveConfirmationMessage", those are missing. Just 
added them.

But "permission_filesystem_item_access_value_ro" and 
"permission_filesystem_item_access_value_no" should not exist. These are 
dynamically generated from permission values, and proper values are "r" and "n" 
(not "ro" and "no"). In earlier versions they were "ro" and "no", so this might 
be conversion issue.

Where do you see these texts? Are these permission values added by yourself 
(can you make new ones with these values)? If you modify them, do they 
disappear?

Original comment by samuli.j...@gmail.com on 30 Mar 2014 at 2:10

GoogleCodeExporter commented 8 years ago
After I updated to 2.5.4, I only had two permissions listed, one with ro and 
one with no.

I'm not sure when they were added - I haven't done anything specific with 
permissions on this install myself, but it's possible that one of my users had.

I deleted them, and haven't tried to get them back. It was while checking both 
and deleting them that I saw the other localization issue.

I did add the default permissions from the button on that screen, and those 
appear to have good localization values.

Thanks!

Original comment by tom.ie...@gmail.com on 30 Mar 2014 at 7:36

GoogleCodeExporter commented 8 years ago
Texts available in 2.5.6

Original comment by samuli.j...@gmail.com on 6 Apr 2014 at 3:18

GoogleCodeExporter commented 8 years ago
Reopening, seems that this commit was not pushed to remote repository, and was 
not included in this release.

Original comment by samuli.j...@gmail.com on 7 Apr 2014 at 4:16

GoogleCodeExporter commented 8 years ago
In 2.5.7

Original comment by samuli.j...@gmail.com on 19 Apr 2014 at 9:42