Update serde/serde_json/serde_derive, use the `?` operator for error handling, fix issue #3

indiv0 / xkcd-rs

Rust bindings for the XKCD web API

https://indiv0.github.io/xkcd-rs/xkcd

Apache License 2.0

4 stars 0 forks source link

Update serde/serde_json/serde_derive, use the `?` operator for error handling, fix issue #3 #9

Closed arqunis closed 7 years ago

arqunis commented 7 years ago

I'm also gonna guess you'd want these changes as seperate commits right? Or is this one frankenstein commit ok?

arqunis commented 7 years ago

Okay that's the last force push i'm gonna do in this pr. (Hopefully) But travis should be able to build the lib without errors once this is merged.

indiv0 commented 7 years ago

Thanks! I'll review this properly in the morning, but the first thing that pops out is that the conventional changelog format requires that the first letter of the subject not be capitalized (e.g. chore: use instead of chore: Use). Sorry to be so nitpicky :P

arqunis commented 7 years ago

Alright uncapitalized the first letters. edit: Also made the title more fitting.

indiv0 commented 7 years ago

Looks great! However it looks like OS X and nightly builds are broken for issues unrelated to this PR. I'm going to merge and then fix the Travis issues later.

Thanks again!