Simplify the compress and decompress functions

indix / kafkajs-lz4

🗜 LZ4 compression codec for KafkaJS

MIT License

15 stars 8 forks source link

Closed ankon closed 3 years ago

ankon commented 4 years ago

Drop the await in the return: This would only be relevant when this is inside a try-catch, otherwise it doesn't matter whether the code "awaits" here or in the caller (which anyways needs to understand promises)
Drop the whole Promise-construction: The actual call into the lz4 library would always immediately run anyways, and blockingly resolve the promise.

paambaati commented 3 years ago

@ankon Thanks, this has been addressed in https://github.com/indix/kafkajs-lz4/commit/5efecce6fc8e746d43bc21298e169eb62eb65b5a. I've added you as a co-author for that commit!