search

indix / kafkajs-lz4

🗜 LZ4 compression codec for KafkaJS
MIT License
15 stars 8 forks source link

Bump lz4 to a working 0.6.3 version #6

Closed Freakachoo closed 3 years ago

Freakachoo commented 3 years ago

There is an issue https://github.com/pierrec/node-lz4/issues/99 that makes version 0.6.4 of the lz4 module not operational. Let's freeze a version on 0.6.3 before the module will be fixed.

paambaati commented 3 years ago

@Freakachoo Can you confirm this works on the 10x, 12x & 14x versions of Node.js? I can't remember correctly but we didn't do this because there was an issue with a specific version of Node.

Freakachoo commented 3 years ago

@paambaati can confirm it works on 12.4.0.

paambaati commented 3 years ago

@Prsna23 Can you please verify that this patch works internally?

Prsna23 commented 3 years ago

@paambaati We have been using version 0.6.0 of lz4 module internally (works on Nodejs 10.x). 0.6.3 works as well.

paambaati commented 3 years ago

@Freakachoo This version doesn't work either.

yarn install v1.22.10
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error https://registry.yarnpkg.com/lz4/-/lz4-0.6.3.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "ENOENT: no such file or directory, link '/Users/gp/Library/Caches/Yarn/v6/npm-lz4-0.6.3-78df6bb69a36d7db6c2e849494876ba6e38e66d6-integrity/node_modules/lz4/build/Release/obj.target/build/Release/lz4.node' -> '/Users/gp/Library/Caches/Yarn/v6/npm-lz4-0.6.3-78df6bb69a36d7db6c2e849494876ba6e38e66d6-integrity/node_modules/lz4/build/Release/obj.target/lz4.node'"

Should we bump it down to 0.6.0?

paambaati commented 3 years ago

v0.6.3 works only after downgrading Yarn to v1.21!

yarn policies set-version 1.21

(See https://github.com/pierrec/node-lz4/issues/99#issuecomment-696129738)

paambaati commented 3 years ago

The lz4 package is too much of a liability and so I've completely rewritten the package. See https://github.com/indix/kafkajs-lz4/pull/7#issuecomment-738652072