indragiek / CocoaMarkdown

Markdown parsing and rendering for iOS and OS X
MIT License
1.2k stars 158 forks source link

Add podspec #20

Closed pronebird closed 8 years ago

pronebird commented 8 years ago

Very minimal support for iOS only. I bet OS X should work out of box if we add :osx to pod spec but I didn't test. The source code is left untouched. I removed CocoaMarkdown/Ono.h from CocoaMarkdown.h because it's not used anywhere but in CMAttributedStringRenderer.m where it is included as Ono.h which should work just fine for the time being.

This work is based on @krodak's effort in #19 but takes into account the fact that you would like to keep submodules.

Good to have in future:

  1. Separate private headers from public. Currently pod spec includes the entire folder but I bet there were some private headers that normally should not be exposed.
  2. Normalize import statements for dependencies, so they follow <LIBRARY/LIBRARY.h> pattern or something like that to avoid collisions.

After merge:

You would have to change the git URL in podspec, add tag to repo and put this tag in pod spec.

krodak commented 8 years ago

@pronebird thanks a lot, unfortunately I didn't have time to integrate those changes in my current fork.

Once this is accepted I might merge it into my Markdown Images support and then post it as PR too :-)

:+1: hope this will be integrated.

mjstallard commented 8 years ago

Any news on this? Although I'm not a CocoaPods kinda guy, @krodak is waiting on this before making a PR for his image support branch (https://github.com/X8/CocoaMarkdown/tree/feature/SupportImageTag) which would be super awesome to see :smile:

indragiek commented 8 years ago

@pronebird @krodak @mjstallard Sorry for the delay, busy times! The podspec looks good to me. Merged. Thank you.

mjstallard commented 8 years ago

@indragiek thank you! :smile: :tada:

pronebird commented 8 years ago

:beers: :beers: :beers:

pronebird commented 8 years ago

Hi,

I am not able to find CocoaMarkdown on CocoaPods.org. Is it possible to pod trunk push the library to the cloud please?

Thank you!