search

indragiek / CocoaMarkdown

Markdown parsing and rendering for iOS and OS X
MIT License
1.2k stars 158 forks source link

Corrected fix for flipped images on macOS 10.15. #56

Closed jlj closed 4 years ago

jlj commented 4 years ago

Improved the original fix for flipped images in [b2397d6]: The SDK version used for generating the application shall be considered as well as the OS version on which the application is running (otherwise an application compiled with Xcode 10 and running on macOS 10,15 would show flipped images).

Thanks to @hisaac for reporting the issue! (See the discussion at https://github.com/indragiek/CocoaMarkdown/pull/52#issuecomment-557681225)

Also, to avoid creating a dedicated PR, this one includes a few minor typo fixes in the README :)

jlj commented 4 years ago

@indragiek Could you merge this pr?

tsfischer commented 4 years ago

@indragiek We'd love it if this could be merged soon too. We need the above fix and would rather pull from the master branch. Thanks in advance!

indragiek commented 4 years ago

Sorry! I only just saw this, my apologies. Looks great.

hisaac commented 4 years ago

Thanks!

jlj commented 4 years ago

Thanks for merging! This enables me to push a next PR from the same branch: Improved rendering and styling of lists #57