search

indragiek / INAppStoreWindow

NSWindow subclass with a highly customizable title bar and traffic lights
BSD 2-Clause "Simplified" License
1.06k stars 162 forks source link

NSDoc / showsProxyIcon implementation #126

Closed ByteProject closed 10 years ago

ByteProject commented 10 years ago

I added a simple property that handles drawing of the document proxy icon in NSDoc apps. In your current implementation the proxy icon was still drawn if you set 'showsTitle' to NO. Drawing of the proxy icon needs to be enabled by setting 'showsProxyIcon' to YES, the default value is NO for now. Thought it would make more sense that way. Documentation is updated as well. You're welcome :)

indragiek commented 10 years ago

This looks fantastic :) One minor request: could you rename the property to showsDocumentProxyIcon? It's a little verbose but it makes it more clear on what the property does.

ByteProject commented 10 years ago

In a solid codebase, you just can't be verbose enough ;) The property is renamed now. Thanks mate :)

indragiek commented 10 years ago

Beautiful, thanks! Merged :)