Closed kolpanic closed 10 years ago
Sorry for the delay, I'll be reviewing this in a day or two :)
Just a few comments (mostly style related things). Thanks for the contribution, and sorry for the delay in reviewing.
@indragiek @jakepetroules I've fixed the style issues you noted.
@jakepetroules If you have the code to calculate the toolbar height, I'd be glad to incorporate it. Thanks.
@kolpanic It's probably easier if we just merge your changes as-is and I can just add the calculation code afterwards.
@indragiek @jakepetroules In that case, I'll leave the toolbarHeight method as-is.
Sounds good. I'll prepare my changes after @indragiek gets this merged.
@kolpanic Thanks, merged :)
@jakepetroules Feel free to open another PR for the calculation code now. While you're at it, could you reformat INAppStoreWindow.m? This PR used spaces instead of tabs. I know you mentioned that we should consider switching to spaces altogether but that's a separate discussion, so tabs are good for now.
@jakepetroules Never mind, I fixed the formatting.
These changes support: