indragiek / INAppStoreWindow

NSWindow subclass with a highly customizable title bar and traffic lights
BSD 2-Clause "Simplified" License
1.06k stars 162 forks source link

Support NSToolbar and Document Windows #156

Closed kolpanic closed 10 years ago

kolpanic commented 10 years ago

These changes support:

indragiek commented 10 years ago

Sorry for the delay, I'll be reviewing this in a day or two :)

indragiek commented 10 years ago

Just a few comments (mostly style related things). Thanks for the contribution, and sorry for the delay in reviewing.

kolpanic commented 10 years ago

@indragiek @jakepetroules I've fixed the style issues you noted.

@jakepetroules If you have the code to calculate the toolbar height, I'd be glad to incorporate it. Thanks.

jakepetroules commented 10 years ago

@kolpanic It's probably easier if we just merge your changes as-is and I can just add the calculation code afterwards.

kolpanic commented 10 years ago

@indragiek @jakepetroules In that case, I'll leave the toolbarHeight method as-is.

jakepetroules commented 10 years ago

Sounds good. I'll prepare my changes after @indragiek gets this merged.

indragiek commented 10 years ago

@kolpanic Thanks, merged :)

@jakepetroules Feel free to open another PR for the calculation code now. While you're at it, could you reformat INAppStoreWindow.m? This PR used spaces instead of tabs. I know you mentioned that we should consider switching to spaces altogether but that's a separate discussion, so tabs are good for now.

indragiek commented 10 years ago

@jakepetroules Never mind, I fixed the formatting.