Switch from tabs to spaces.

[jakepetroules]

Spaces are default and preferred in Xcode for Objective-C (and most style guidelines in general). Tabs are preferred for plists.

[indragiek]

I'm gonna have to think on this one for a bit :grin:

[jakepetroules]

You can see from the diff that even GitHub prefers spaces. :)

Notice (tabs)

void function(void *param1,
                            void *param2);

vs (spaces)

void function(void *param1,
              void *param2);

[jakepetroules]

Please "decide" about this soon too. :P

[indragiek]

Weirdly enough, GitHub's own Objective-C style guidelines (which I tend to follow pretty closely) recommend tabs over spaces :P

[jakepetroules]

I consider Apple/Xcode defaults more authoritative. :)

Also, some random Apple Open Source files:

• http://opensource.apple.com/source/CF/CF-855.14/CFBundle.c?txt
• http://opensource.apple.com/source/WebKit2/WebKit2-7537.74.9/Platform/mac/LayerHostingContext.mm?txt
• http://opensource.apple.com/source/WebKit2/WebKit2-7537.74.9/UIProcess/mac/WKFullScreenWindowController.mm?txt
• http://opensource.apple.com/source/objc4/objc4-551.1/runtime/NSObject.mm?txt

http://www.webkit.org/coding/coding-style.html "Use spaces, not tabs. Tabs should only appear in files that require them for semantic meaning, like Makefiles."

http://llvm.org/docs/CodingStandards.html#use-spaces-instead-of-tabs "In all cases, prefer spaces to tabs in source files. People have different preferred indentation levels, and different styles of indentation that they like; this is fine. What isn’t fine is that different editors/viewers expand tabs out to different tab stops. This can cause your code to look completely unreadable, and it is not worth dealing with."

github/objective-c-conventions#57

[indragiek]

I'm going to have to close this one. I realize that Apple prefers spaces over tabs, but they're just one entity and many different places have different conventions. I don't think there is a "correct" choice because it's a purely subjective decision. I personally have been using tabs in all my projects for a while now, so I'm going to stick with tabs to keep consistency with my own style (which doesn't agree with Apple's, but I don't consider using tabs to be "wrong" in any form).

[jakepetroules]

Oh well, at least I tried to convert you to the the Right Way® :)

The project is still inconsistent though, so we should make sure ALL files are tabbed (and maybe this related to #154, but I could only find tabs > spaces examples when I looked, not the inverse).