search

indragiek / INAppStoreWindow

NSWindow subclass with a highly customizable title bar and traffic lights
BSD 2-Clause "Simplified" License
1.06k stars 162 forks source link

Update podspec for INAppStoreWindow 1.5. #173

Closed jakepetroules closed 10 years ago

jakepetroules commented 10 years ago

I'm not really familiar with CocoaPods so you'll have to sanity check me on this one. Don't forget to tag the release in Git!

indragiek commented 10 years ago

Looks good at a glance, but did you run pod lint? It can tell you if there are any problems with the spec.

jakepetroules commented 10 years ago

Sorry, I don't use CocoaPods nor do I have it installed, I thought I'd leave the linting step to you. ;)

indragiek commented 10 years ago

No problem :) I'll run it when I'm back at my computer.

jakepetroules commented 10 years ago

Did you get a chance to test this yet?

indragiek commented 10 years ago

pod spec lint won't run until the release is tagged on GitHub, and I'm waiting on #174 to tag it. If it isn't updated in a few days I'll just go ahead and tag it :)

jakepetroules commented 10 years ago

OK. I have some native title rendering stuff I was working on, maybe we can get that in for 1.5 too.

jakepetroules commented 10 years ago

See #176

jakepetroules commented 10 years ago

Cool. Do we submit this file to CocoaPods now?

indragiek commented 10 years ago

I'm about to tag the release on GH, lint it, and then push to the master specs repo.

jakepetroules commented 10 years ago

Excellent. I improved the doc comments a lot since the 1.4 release so the documentation should be a lot better on the CocoaPods docs (http://cocoadocs.org/docsets/INAppStoreWindow/)

jakepetroules commented 10 years ago

Before you tag, https://github.com/indragiek/INAppStoreWindow/blob/master/README.md has absolute URLs (for the screenshots), could you make those relative so they actually show up on CocoaPods?

indragiek commented 10 years ago

How do you do relative URLs from the README.md file?

jakepetroules commented 10 years ago

See here for example: https://github.com/sparkle-project/Sparkle

Basically, URLs are relative to the repo root.

indragiek commented 10 years ago

Done! I had to submit a request to claim INAppStoreWindow as my pod, so I have to wait for approval before submitting the spec to the master repo.