indragiek / INAppStoreWindow

NSWindow subclass with a highly customizable title bar and traffic lights
BSD 2-Clause "Simplified" License
1.06k stars 162 forks source link

Exit full screen mode in Yosemite #180

Open TomLiu opened 10 years ago

TomLiu commented 10 years ago

In Yosemite click the green traffic light can enter and exit full screen mode. INAppStoreWindow didn't show traffic light under full screen mode, users can't exit like other apps by clicking the green traffic light.

mz2 commented 10 years ago

I've hit the same issue too. Any ideas about a fix or a workaround?

martinjbaker commented 10 years ago

I don't. I only use INAppStoreWindow for the ability to change title bar colour, so I'm probably going to abandon it and move to a textured window with custom content view.

Kapeli commented 10 years ago

I was able to fix this issue and get the buttons to show for me by disabling these 3 lines in Yosemite: https://github.com/indragiek/INAppStoreWindow/blob/45c5f6bb9f07185b21bdd0dd7c7782d05ff46106/INAppStoreWindow/INAppStoreWindow.m#L1161-L1163.

As far as I can tell, the issue is caused by INAppStoreWindow trying to change the frame of the buttons (even if you didn't customise anything related to the window buttons). Disabling the change of frame of docIconButton might also be needed for document-based apps, not sure.

Unfortunately I don't have the time to look into this further and fix it properly (i.e. find a way to get the buttons to actually change frame reliably so they can be customised), so I can't submit a pull request.

mz2 commented 10 years ago

I can confirm that your workaround works on Yosemite. I've put our version of the workaround here: https://github.com/mekentosj/INAppStoreWindow/commit/23e06df5e9d5dba7afdab21bb94f62c7202fff1e

This needs some further work still -- the traffic light buttons don't center again after coming back from fullscreen with this workaround in place (they do center again after the window is resized after that).

ingon commented 9 years ago

Maybe this could be the answer: https://github.com/indragiek/INAppStoreWindow/pull/192

ingon commented 9 years ago

@indragiek & @jakepetroules this seems to affect a lot of people, do you guys think we can get this fixed/merged?

cparnot commented 9 years ago

I have the same issue.