search

indragiek / INAppStoreWindow

NSWindow subclass with a highly customizable title bar and traffic lights
BSD 2-Clause "Simplified" License
1.06k stars 162 forks source link

Replaced the deprecated API (maintaining compatibility) #198

Closed torinkwok closed 9 years ago

torinkwok commented 9 years ago

-initWithBase64Encoding: has been deprecated in OS X v10.9 and later, so when we compile source code in OS X v10.9 and later, there will be some compile-time warnings:

screen shot 2015-04-02 at 1 51 24

I replaced them with initWithBase64EncodedString:options: that is available in OS X 10.9 and later. And for the compatibility considerations, I maintained the deprecated method.

For details, please see Commits.

torinkwok commented 9 years ago

Hello?

indragiek commented 9 years ago

Sorry about the delay, I'll check this out ASAP.

Indragie Karunaratne

On Thu, Apr 2, 2015 at 2:47 PM, NSTongG notifications@github.com wrote:

Hello?

Reply to this email directly or view it on GitHub: https://github.com/indragiek/INAppStoreWindow/pull/198#issuecomment-89040984

torinkwok commented 9 years ago

😄Fine.

indragiek commented 9 years ago

@TongG Thanks for your patience. Few minor comments, should be good to go otherwise.

torinkwok commented 9 years ago

Okay, I fixed them.

torinkwok commented 9 years ago

Please check it out.

torinkwok commented 9 years ago

How about now?

indragiek commented 9 years ago

Looks good.

torinkwok commented 9 years ago

Thx. 🍺