search

indrimuska / angular-selector

A native AngularJS directive that transform a simple <select> box into a full html select with typeahead.
http://indrimuska.github.io/angular-selector
MIT License
96 stars 36 forks source link

Renamed .selector to .selector-item as it is duplicated #15

Closed kmturley closed 8 years ago

kmturley commented 8 years ago

Suggestion to use .selector as top level class only, and use .selector-item for duplicates items below

Fix for this issue: https://github.com/indrimuska/angular-selector/issues/14

indrimuska commented 8 years ago

Hey @kmturley, thanks for sharing this idea. It looks good to me, just perform the following updates and let's create a new Major version (since it will be incompatible with the current one) :+1:

kmturley commented 8 years ago

@indrimuska ok have made those changes! seems to work fine for me. This will make it alot easier to control the top level classes now :)

indrimuska commented 8 years ago

Ok, you only missed the directive restriction "C", but don't worry I will add it for you. Thank you man! :)

indrimuska commented 8 years ago

This new feature has been released in version 1.0.0. This also closes #14.