search

indrimuska / angular-selector

A native AngularJS directive that transform a simple <select> box into a full html select with typeahead.
http://indrimuska.github.io/angular-selector
MIT License
96 stars 36 forks source link

fix: variables are not defined #42

Closed bogwro closed 8 years ago

bogwro commented 8 years ago

$filter, $timeout, $window, $http, $q are not defined before they are used. Error is visible once file is minified. ESLinter reports it as well!

it is a general good practice to not leak variables to the global scope recommended settings already define that scenario "eslint:recommended"

indrimuska commented 8 years ago

Thank you man! 👍