indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
124 stars 29 forks source link

Read server's ISUPPORT and get prefix there #101

Open 14mRh4X0r opened 8 years ago

14mRh4X0r commented 8 years ago

Also stores the ISUPPORT parameters in an easily accessible HashMap and fixes a slight parsing bug with IRCv3 message tags

indrora commented 8 years ago

There's deeper places that this should be handled.

Notably, pIRCbot is hard-coded to say that v means + and o means @.

indrora commented 8 years ago

Second quick check: how well does the IETF document line up with http://www.irc.org/tech_docs/005.html ?

14mRh4X0r commented 8 years ago

I'll update this pull request later with an implementation on a deeper level. The IETF document matches the irc.org doc as far as I can tell, but the latter does provide more information about real-world implementations.

indrora commented 8 years ago

I'd like IRCService to be able to tell what the ISUPPORT blocks state. This way, we can strip out the nick prefixes (and handle things like the absolutely strange $foo channel type that I encountered)

14mRh4X0r commented 8 years ago

As my local version is now, PircBot has a Map<String, String> getISupport(). It requires more rewriting than I anticipated.