indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
124 stars 29 forks source link

Hostname is not checked against SSL certificate #126

Open thegrumble opened 8 years ago

thegrumble commented 8 years ago

SSL certificates are checked to be valid, but no attempt is made to match the hostname against the hostname(s) the SSL certificate is valid for.

I implemented a quick fix for this: https://github.com/xnrand/Atomic/commit/e2ed609735d3b628bdf4c15eea7e63b1d30174b It's not polished enough for a pull request, and I haven't tested it against anything other than Marshmallow, but I hope it helps :smile: