search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

Push notification not forwarding to channel with highlight #14

Closed qwertfisch closed 10 years ago

qwertfisch commented 10 years ago

When a highlight occurs in one channel, the message appears as push notification. When I click on the notification I am only directed to the Atomic app, but it opens with the last active channel, not with the channel where the highlight occured. So I need to manually search through my channels.

I think it should not be a problem switching the channel accordingly?

Also when the app is already in foreground it would be great not getting a push notification on highlight but a pop-up dialog (configurable!) where I can switch to the channel with one touch.

indrora commented 10 years ago

at commit @47e942e9347f4 the behavior is now to send you to the most recent highlight in the stack.

qwertfisch commented 10 years ago

I’m sorry to say but it seems not to work as expected. When I receive a highlight and select the push notification, Atomic still opens with the last used channel, not the one with the latest highlight. I have used the latest commit @631780e7e602470e0276d1833f797e81a7651d67.

But I like your newest GUI changes with the icons, great work.

indrora commented 10 years ago

Ack, I didn't actually push 47e942e. My bad. 54a5365b3f6a294911b0fcf66fb6e83e361efdac also brings a regression fix.

qwertfisch commented 10 years ago

Thank you for your effort. I just tested the new commit, unfortunately still with no success. Maybe I am doing something wrong …? I can create screenshots or steps to reproduce, but it is late now. Has to wait until Thursday.

qwertfisch commented 10 years ago

I have found time to test again with the newest release. There is still no difference. Either I am expecting other things than you, or this feature does not work properly. Can you confirm my steps to reproduce?

Steps to reproduce

  1. Open a connection with at least two channels
  2. Select the first channel A
  3. Go back to home screen
  4. Cause a highlight in the second channel B (via another client)
  5. Expected and actual result: a notification is generated in the notification bar
  6. Open the notification and click on it
  7. Expected: Atomic opens and changes the current channel to B, where the highlight occured
    Actual: Atomic opens, but remains on the last displayed channel A.

Variant

Omit step 3, but remain on first channel A