search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

Do not display short numbers as phone number links #21

Closed qwertfisch closed 10 years ago

qwertfisch commented 10 years ago

Description

Short numbers with two or more digits are displayed as links. On touch they open the phone app with the digits predialed. This is even done for the message timestamps.

I am not sure whether I just noticed it or it is a new feature in the pre-1.16 git head, but I think of this “feature” very annoying. It is very useful for links, but not so for very short numbers, hence the timestamps. Maybe you could provide an option to select whether numbers / URLs are linked? It would also help (if possible) to set a minimal number length, because two digits seems quite useless as a phone number.

indrora commented 10 years ago

This is technically a bug in the android Linkify options, however it's all flags. I'll look into adding options.

qwertfisch commented 10 years ago

Ok this might be directly caused by some linkify library, but you are using it. When I start a text editor there is also no link, so it is responsibility of Atomic to clarify which text should be linked and which not.

I think it’s a bug when even the timestamps are linked because do clearly do not carry information about URLs or phone numbers.

indrora commented 10 years ago

Fixed. Future should have options for how to create links.