search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

No mIRC colors when using solarized theme #32

Closed sdegrande closed 9 years ago

sdegrande commented 10 years ago

Ansi colors in messages are not displayed when using the solarized theme. Only italic and bold is displayed correctly.

Thx for your work.

indrora commented 10 years ago

Please confirm this happens on 1.18

sdegrande commented 10 years ago

Actually, with 1.18, ansi colors are not displayed (no matter the chosen theme) as soon as «display colors to highlight specific events» (i don't know how this option is called in English, my interface is in French) is enabled. Even with default theme, dark or not.

When the option is disabled, everything is fine.

Thanks for your work.

indrora commented 10 years ago

When you say ANSI colors, are you referring to the mIRC color spec or ANSI Color escapes?

sdegrande commented 10 years ago

Ah yes sorry. That's mirc color codes (<ctrl+c>3 for green, and so on). Sorry again for the confusion.

sdegrande commented 10 years ago

Mhhh... I meant < ctrl + c >3 (I hope github will not remove it, with blanks inserted)

indrora commented 10 years ago

This looks like a side effect of cleaning up message rendering.

indrora commented 10 years ago

Can I get confirmation that this is resolved in HEAD?

sdegrande commented 10 years ago

Sorry, I can not build it myself, and so I can not check the current git version.

MSEMJEJME commented 10 years ago

Haven't been able to duplicate

Sent from my Windows Phone

From: Morgan Gangweremailto:notifications@github.com Sent: ‎18/‎08/‎2014 23:06 To: indrora/Atomicmailto:Atomic@noreply.github.com Subject: Re: [Atomic] No mIRC colors when using solarized theme (#32)

Can I get confirmation that this is resolved in HEAD?

Reply to this email directly or view it on GitHub: https://github.com/indrora/Atomic/issues/32#issuecomment-52562468