search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

Links are clickable but try to call a number #47

Closed qwertfisch closed 9 years ago

qwertfisch commented 9 years ago

When I get a link I can click on it, but instead of opening the browser, the phone app opens. There is a workaround: select the link with long-press and copy the text. Then clicking on the link opens an intent to a browser, but only once.

I might be wrong, but I think this was no issue until 1.13 or 1.14. Also #21 is related with this.

indrora commented 9 years ago

I can't seem to reproduce this.

MSEMJEJME commented 9 years ago

I've seen this happen but it's random numbers

Sent from my Windows Phone

From: Morgan Gangweremailto:notifications@github.com Sent: ‎18/‎08/‎2014 23:05 To: indrora/Atomicmailto:Atomic@noreply.github.com Subject: Re: [Atomic] Links are clickable but try to call a number (#47)

I can't seem to reproduce this.

Reply to this email directly or view it on GitHub: https://github.com/indrora/Atomic/issues/47#issuecomment-52562293

indrora commented 9 years ago

Android chooses how to open links. Strings of digits are considered phone numbers if they're 5 digits, or match an international phone number style, and are linked as well.

qwertfisch commented 9 years ago

It is weird, I cannot reproduce it when I send myself some links. But it still occurs now and then. Sometimes it helps clicking a second time on the link. Sometimes I need to mark it with the clipboard, and sometimes I have to copy it to clipboard before it is recognized as link. And in case of the latter, the trick only works once. On the next click it is a phone number again.

All in all would be nice, given there is an app-specific setting, to disable the number linking in Atomic at all. This would also solve #21.

qwertfisch commented 9 years ago

More details: in some cases (I cannot say when or why this happens) the linkify routine gets crazy: no matter what or where I click, it wants to open the number dial app. This can be stopped with the clipboard trick mentioned above. Maybe I can reproduce it properly, I’ll let you know.

indrora commented 9 years ago

I've not been able to reliably reproduce the dialer opening for obviously non-phone links; I will most likely be adding a set of tickboxes to make sure to not linkify the wrong things.