search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

Bouncer playback triggers notifications #60

Open Poorchop opened 9 years ago

Poorchop commented 9 years ago

When playback is loaded after connecting to my bouncer, all old highlights trigger my notification events. It also seems to trigger a new event for every single highlight, and since I have a decent sized playback with a number of old highlights, my phone goes wild for a while shortly after connecting to my bouncer.

indrora commented 9 years ago

Until someone writes a plugin for ZNC that adds an "X of total" tag I can't tell when ZNC is spewing backlog at me vs. when normal messages are coming in.

Poorchop commented 9 years ago

I'm not sure how they do it, but the other Android clients I've tried are able to distinguish bouncer playback from new messages. The playback is usually even surrounded by notices like *Begin playback and *End of playback, or something to that effect.

In any case, this was merged fairly recently, and according to the committer, that should allow notifications to be suppressed during playback. Maybe the other clients are just using guesswork to distinguish playback from new messages.

indrora commented 9 years ago

ZNC stops sending <***> notes whenever you ask for timestamps. It's a touch idiotic, but It's ZNC.

This may also be handy for #49 . I'll consider it for 1.20 or so, probably for 2.0

indrora commented 9 years ago

My copy of ZNC has yet to be patched against this, so I have nothing to test against. I'm earmarking this issue though, so I keep it alive.