search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
123 stars 29 forks source link

Added support for halfop and dehalfop and added # of users in a channel #88

Closed paytonq-zz closed 9 years ago

paytonq-zz commented 9 years ago

I saw that issue #87 was requesting halfop support, so I implemented it. I tested the implementation on a Nexus 5 Emulator running 5.0.1 on Mibbit IRC.

Also implemented issue #33, which was very straightforward (Listing the number of users in a channel).

Edit: Note, some of the new translations may be somewhat off.

indrora commented 9 years ago

Some nits about style; don't commit the IDEA files (I know i need to add them to .gitignore).

As well, the "standard" (if you can call it a standard) is that halfops get % as a prefix.

paytonq-zz commented 9 years ago

Should I revert the idea files?

indrora commented 9 years ago

Revert the IDEA files, and make sure that the translations make their way to Crowdin.

paytonq-zz commented 9 years ago

Right, and switch halfops to %. Working on it right now

indrora commented 9 years ago

Awesome :beers:

paytonq-zz commented 9 years ago

Haven't used Crowdin before, what exactly do I do?

paytonq-zz commented 9 years ago

Also, when I added halfop and dehalfop I fixed a bug that was causing the ban and kick functionalities to be reversed.

indrora commented 9 years ago

Awesome beans, looks like all is right with the world.

paytonq-zz commented 9 years ago

Do you still need me to add the translations to Crowdin?

indrora commented 9 years ago

It'd be really nice to see them migrated up right now, but I can add them when I do a sync with Crowdin.

I'll have to add the English versions (as source lines) within Crowdin, but I'll be able to update the translations at the same time.

paytonq-zz commented 9 years ago

Ok, thanks.