search

inducer / arraycontext

Choose your favorite numpy-workalike!
6 stars 11 forks source link

Add typing to ArrayContext #154

Closed alexfikl closed 2 years ago

alexfikl commented 2 years ago

This uses the new Array and Scalar protocols to add some type annotations to ArrayContext.

What other places did you have in mind in https://github.com/inducer/arraycontext/pull/153#discussion_r843365012? I looked a bit through the container stuff, but they're all nested, so there aren't many places where it makes sense to use these.

inducer commented 2 years ago

Thanks! I'll hold off on a review until after https://github.com/inducer/pytools/pull/124.

inducer commented 2 years ago

https://pypi.org/project/pytools/2022.1.3/

alexfikl commented 2 years ago

pypi.org/project/pytools/2022.1.3

Needs a tag in pytools too? I'm guessing that's why the downstream tests are failing..

inducer commented 2 years ago

Yep, sorry. Forgot to push that!

inducer commented 2 years ago

(now done)

alexfikl commented 2 years ago

Thank you!

inducer commented 2 years ago

LGTM, thanks!