Closed alexfikl closed 2 years ago
Thanks! I'll hold off on a review until after https://github.com/inducer/pytools/pull/124.
Needs a tag in pytools
too? I'm guessing that's why the downstream tests are failing..
Yep, sorry. Forgot to push that!
(now done)
Thank you!
LGTM, thanks!
This uses the new
Array
andScalar
protocols to add some type annotations toArrayContext
.What other places did you have in mind in https://github.com/inducer/arraycontext/pull/153#discussion_r843365012? I looked a bit through the container stuff, but they're all nested, so there aren't many places where it makes sense to use these.