search

inducer / arraycontext

Choose your favorite numpy-workalike!
6 stars 11 forks source link

Fix swapped `map`/`reduce_func` in `test_container_scalar_map` #212

Closed inducer closed 1 year ago

inducer commented 1 year ago

This started (rightfully) failing with numpy 1.24. I'm not even sure what the prior code was trying to accomplish. I'm still not sure I get what it's trying to do now.

cc @alexfikl as the person who last touched that code.

inducer commented 1 year ago

Merging right away because CI on main is broken by this.

alexfikl commented 1 year ago

Hm, I think that just randomly tested that the traversal doesn't crash anywhere for weirder inputs. I'll take a look and see how to modify them to actually check the result is correct!