Forbid setting `force_device_scalars=False`

inducer / arraycontext

Choose your favorite numpy-workalike!

6 stars 11 forks source link

Forbid setting `force_device_scalars=False` #278

Closed majosm closed 1 month ago

majosm commented 2 months ago

Deprecated since 2022, AFAIK no longer needed?

To-do:

[x] Merge https://github.com/inducer/meshmode/pull/429
[x] Merge https://github.com/inducer/grudge/pull/358

majosm commented 2 months ago

Looks like the default value of force_device_scalars will need to be changed in the meshmode/grudge array context constructors before this can be merged. I'll wait until this gets a tentative go-ahead before doing that.

inducer commented 2 months ago

Very much in favor as well!

majosm commented 2 months ago

Ruff errors appear to be unrelated, so I think this is ready for a look. https://github.com/inducer/meshmode/pull/429 and https://github.com/inducer/grudge/pull/358 should probably get merged before this.